Repository navigation
fix: handle instances of deleted labs in running/finished labs views - #323
Open
italovalcy wants to merge 2 commits into
Open
italovalcy wants to merge 2 commits into
italovalcy wants to merge 2 commits into
Conversation
…322) allowed_groups_by_lab only contains existing labs, so instances whose lab was deleted raised KeyError for group owners/assistants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322
allowed_groups_by_labis built only from existing labs, so lab instances whose lab was deleted raisedKeyErrorin the permission check (/finished_labs, and the same pattern in the running labs view) for non-admin group owners/assistants.Use
allowed_groups_by_lab.get(li.lab_id, {})so such instances are treated as having no allowed groups. Admins and the instance's own user still see them (with the existing "Unknow Lab" title).🤖 Generated with Claude Code