Skip to content

Add space before hyphen so the assignee mention resolves - #186

Merged
ale210 merged 1 commit into
mainfrom
155-fix-assignee-mention
Sep 5, 2026
Merged

Add space before hyphen so the assignee mention resolves#186
ale210 merged 1 commit into
mainfrom
155-fix-assignee-mention

Conversation

@ale210

@ale210 ale210 commented Sep 5, 2026

Copy link
Copy Markdown
Member

One character. Part of #155.

Problem

The reminder greeting is Hello ${assignees}-, which renders as Hello @username-. GitHub does not parse that as a mention. The hyphen is a legal username character so the parser consumes it, and since a username cannot end in a hyphen the whole match fails — no link, and no mention notification.

Verified against GitHub's own renderer (POST /markdown, mode gfm):

Text Rendered
@ExperimentsInHonesty- no mention link
@ExperimentsInHonesty - mention link
@ExperimentsInHonesty, mention link
@ExperimentsInHonesty! mention link

With more than one assignee only the last is affected — @a, @b- produces one link instead of two.

Visible in the first live run: the comment on #158 shows Hello @ExperimentsInHonesty- as plain text.

Assignees still receive a subscriber notification because they are assigned, so this is not silent — but the reminder is not actually tagging anyone, which is most of its purpose.

Fix

Hello ${assignees}-Hello ${assignees} - in add-update-instructions-template.md.

Re-rendered after the change: one user-mention link, as expected.

Note

This comes from automate-the-org's shipped template, so hackforla/website and hackforla/tdm-calculator have the same broken greeting in their installed copies, and any new install will too until the upstream example is fixed. Deliberately out of scope here.

@ale210
ale210 merged commit 2224804 into main Sep 5, 2026
1 check passed
@ale210
ale210 deleted the 155-fix-assignee-mention branch September 5, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant