Repository navigation
Migrate to React Flow 12 and fix rendering regressions - #74
Merged
Merged
Conversation
added 3 commits
October 22, 2026 16:13
Upgrade to @xyflow/react 12.12.0, adapt internal-node geometry and dimensions, preserve model format 2, and keep measurement updates out of dirty tracking and resize history. Initialize PNG capture from locally measured export nodes and await viewport updates. Preserve Modelizer's dark canvas palette. Validation: lint, 527 tests in 34 files (514 retained plus 13 regressions), and production build pass. Existing MySQL parser chunk-size warning remains. Browser comparison against main covered a 20-class model, light/dark rendering, all three views, and matching conceptual PNG previews at 2396 x 1595. Verified pen gesture undo/redo and annotation-only preview on localhost. Downloaded-file inspection remains unverified after the browser download wait timed out; exhaustive manual tool/gesture checks remain for review.
Preserve derived association helper measurements so associative links survive controlled-node updates and view switches. Make sidebar focus exclusive across nodes and edges, add focus tooltips, and render composition diamonds without clipping or transparency overlap. Add regression coverage for ordinary/reflexive associative links and focus in all three views. Record migration validation, remaining manual checks, and the deferred class-panel layout ideas in docs/react-flow-12-review.md. Validation: lint passes; all 541 tests in 35 files pass; build:ci passes with the existing MySQL parser size warning. Browser checks confirm composition colors in both themes, associative rendering, and unclipped real PNGs across all three views plus annotations-only output. Native download completion and exhaustive manual interaction checks remain documented for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade React Flow 11.11.4 to @xyflow/react 12.12.0 while preserving model format 2 and compatibility with older files. Adapt measured geometry, controlled nodes, history, serialization, and asynchronous PNG export initialization.
Fix disappearing associative links, make sidebar focus exclusive across nodes and edges in all views, add focus tooltips, and correct composition diamond clipping and transparency. Ignore local /tmp files. Deferred class panel layout ideas and remaining manual checks are recorded in docs/react-flow-12-review.md.
Validation: npm run lint, all 541 tests in 35 files, and npm run build:ci pass. Browser comparisons covered a 20-class model, all three views, and light/dark appearance. Follow-up browser checks verified associative links, composition diamonds, and actual PNG bytes with annotations, negative coordinates, hidden notes/areas, and the physical footer. Native PNG download automation timed out; exhaustive manual interaction checks remain documented. The existing MySQL parser chunk-size warning is unchanged.