fix(cli): Respect enable_hints config option - #2006
Merged
Merged
Conversation
The `enable_hints` setting was parsed but never consulted, so hints kept printing even with `enable_hints: false` in the config file. `--cli-config` used default_value_t with Config's Display impl returning an empty string, so clap re-parsed that empty default through parse_config on every real run, discarding whatever Config::new() had loaded from ~/.config/osc. User config (e.g. enable_hints: false) was silently ignored. Switch the field to `skip` so Config::new() result is used directly. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
changed the title
enable_hints setting was parsed but never consulted, so hints kept
printing even with enable_hints: false in the config file.
--cli-config used default_value_t with Config's Display impl returning
an empty string, so clap re-parsed that empty default through
parse_config on every real run, discarding whatever Config::new() had
loaded from ~/.config/osc. User config (e.g. enable_hints: false) was
silently ignored. Switch the field to skip so Config::new() result is
used directly.
Assisted-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
changed the title
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
enable_hintssetting was parsed but never consulted, so hints keptprinting even with
enable_hints: falsein the config file.--cli-configused default_value_t with Config's Display impl returningan empty string, so clap re-parsed that empty default through
parse_config on every real run, discarding whatever Config::new() had
loaded from ~/.config/osc. User config (e.g. enable_hints: false) was
silently ignored. Switch the field to
skipso Config::new() result isused directly.
Assisted-By: Claude Sonnet 5 noreply@anthropic.com
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com