Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gql/transport/requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ def connect(self):
# Creating a session that can later be re-use to configure custom mechanisms
self.session = requests.Session()

if self.headers:
self.session.headers.update(self.headers)

# If we specified some retries, we provide a predefined retry-logic
if self.retries > 0:
adapter = HTTPAdapter(
Expand Down
22 changes: 22 additions & 0 deletions tests/test_aiohttp.py
Original file line number Diff line number Diff line change
Expand Up @@ -1918,3 +1918,25 @@ async def handler(request):
await session.execute("qmlsdkfj")

assert "request should be a GraphQLRequest object" in str(exc_info.value)


@pytest.mark.asyncio
async def test_aiohttp_save_headers_in_session():
"""Regression test for issue #613"""
from gql.transport.aiohttp import AIOHTTPTransport

transport = AIOHTTPTransport("url", headers={"test": "header"})
await transport.connect()
assert transport.session
assert transport.session.headers["test"] == "header"

transport2 = AIOHTTPTransport("url")
await transport2.connect()
assert transport2.session

del transport.session.headers["test"]

assert transport.session.headers == transport2.session.headers

await transport.close()
await transport2.close()
21 changes: 21 additions & 0 deletions tests/test_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -1272,3 +1272,24 @@ def test_code():
assert pi == Decimal("3.141592653589793238462643383279502884197")

await run_sync_test(server, test_code)


def test_requests_save_headers_in_session():
"""Regression test for issue #613"""
from gql.transport.requests import RequestsHTTPTransport

transport = RequestsHTTPTransport("url", headers={"test": "header"})
transport.connect()
assert transport.session
assert transport.session.headers["test"] == "header"

transport2 = RequestsHTTPTransport("url")
transport2.connect()
assert transport2.session

del transport.session.headers["test"]

assert transport.session.headers == transport2.session.headers

transport.close()
transport2.close()
Loading