Fix TAP Verifier address typo in the config example, note v2.0.2 graph_tally_collector_address - #1119
Open
cargopete wants to merge 1 commit into
Open
Conversation
…h_tally_collector_address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration example on the TAP page sets
receipts_verifier_address_v2to0x8f69F5C07477Ac46FBc491B1E6D91E2be0111A9e. The real TAP Verifier is…E2bb0111A9e, which is what the address table on the same page andpackages/horizon/addresses.jsonhave. There is no contract at the typo address, so anyone who copies the example breaks receipt verification. #1112 fixed the table but missed the example.This also adds one line to the v2.0.0 upgrade notes.
indexer-service-rsandindexer-tap-agentv2.0.2 filter escrow accounts byblockchain.graph_tally_collector_address, which defaults to a placeholder. A config written from this page loads no escrow accounts, and every receipt fails withNo sender found for signer. graphprotocol/indexer-rs#1014 removed the field in v2.1.0.I checked it by parsing the page's example with the v2.0.2 config crate, where the collector resolves to
0x4444…, and by running the escrow query against the network subgraph with both addresses. The placeholder returns no accounts and the TAP Verifier returns the expected ones.