Repository navigation
Fix Grand.Web.Admin.Tests build: update LoginControllerTwoFactorTests to current LoginController API - #1016
Draft
KrzysztofPajak with Copilot wants to merge 2 commits into
Draft
Fix Grand.Web.Admin.Tests build: update LoginControllerTwoFactorTests to current LoginController API#1016KrzysztofPajak with Copilot wants to merge 2 commits into
KrzysztofPajak with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build
Fix Grand.Web.Admin.Tests build: update LoginControllerTwoFactorTests to current LoginController API
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI "build" job failed with
CS0246becauseLoginControllerTwoFactorTestscould not resolveIGrandAuthenticationService. Fixing that exposed two more breaks from drift against the currentLoginControllerconstructor, plus a runtimeNullReferenceExceptionin one test.Changes, all in
src/Tests/Grand.Web.Admin.Tests/Controllers/LoginControllerTwoFactorTests.cs:Grand.Web.Common.Security.AuthenticationforIGrandAuthenticationService.Grand.Web.Common.LocalizationforIRequestTranslationService.ITranslationServiceis nowIRequestTranslationService.IMessageProviderServiceis nowICustomerMessageProviderService.LoginControllersignature.IContextAccessormockDefaultValue = DefaultValue.Mock, asLoginControllerExternalSignInTestsdoes.SecondStep_ValidCode_SignsInToThePanelthrew aNullReferenceExceptioninBaseLoginController.SignInAction.Test-only change; no production code is touched.