Use declaration_markdown only for form declarations - #2334
Merged
Conversation
Update the form document content to the latest schema version.
As of May 2026 all form documents now have a `declaration_markdown` property, and the `declaration_text` property is no longer updated (see govuk-forms/forms-admin#2620). However, form documents can still have the `declaration_text` property, and some form documents have no declaration (blank `declaration_markdown`) but a non-empty `declaration_text`. To stop a declaration from being shown in this scenario, this commit removes the code that showed the contents of `declaration_text`.
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Fixes issue reported by user in Zendesk ticket https://govuk.zendesk.com/agent/tickets/6829206.
As of May 2026 all form documents now have a
declaration_markdownproperty (confirmed usinggds aws forms-prod-support -- forms data_api -d forms-admin -s $'SELECT COUNT(*) FROM form_documents WHERE NOT content ? \'declaration_markdown\';'), and thedeclaration_textproperty is no longer updated (see govuk-forms/forms-admin#2620).However, form documents can still have the
declaration_textproperty, and some form documents have no declaration (blankdeclaration_markdown) but a non-blankdeclaration_text.To stop a declaration from being shown in this scenario, this PR removes the code that showed the contents of
declaration_text. We also update all specs to usedeclaration_markdown.Things to consider when reviewing