Ensure that unconditional routes are not deleted when changing answer settings - #3105
Merged
lfdebrux merged 1 commit intoSep 11, 2026
Conversation
… settings When the multiple branches feature is enabled, an only one option selection question can have an unconditional route if has more than 10 selection options (and didn't have any conditional routes added before the multiple branches feature was enabled). We want to ensure that when the answer settings are changed for such a question that the unconditional route is not deleted. This is similar to how (when the multiple branches feature is not enabled) we don't delete secondary skip conditions for a question when changing the answer settings. Previously we were doing this by deleting only check conditions for a page, as secondary skip conditions have a different page for the routing and check pages. However, unconditional routes in the multiple branches feature do have the same check page as routing page, so this logic was deleting unconditional routes. Instead, in this commit we delete only conditions that have non-nil `answer_value`. This excludes both unconditional routes and secondary skip conditions, and so should work when the multiple branches feature is either enabled or disabled.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3105.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
SamJamCul
approved these changes
Sep 11, 2026
lfdebrux
deleted the
ldeb-do-not-delete-generic-routes-when-changing-selection-question-answer-type
branch
September 11, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
When the multiple branches feature is enabled, an only one option selection question can have an unconditional route if has more than 10 selection options (and didn't have any conditional routes added before the multiple branches feature was enabled).
We want to ensure that when the answer settings are changed for such a question that the unconditional route is not deleted.
This is similar to how (when the multiple branches feature is not enabled) we don't delete secondary skip conditions for a question when changing the answer settings.
Previously we were doing this by deleting only check conditions for a page, as secondary skip conditions have a different page for the routing and check pages. However, unconditional routes in the multiple branches feature do have the same check page as routing page, so this logic was deleting unconditional routes.
Instead, in this commit we delete only conditions that have non-nil
answer_value. This excludes both unconditional routes and secondary skip conditions, and so should work when the multiple branches feature is either enabled or disabled.Note: a warning message will be shown on the page to change the answer type for an only one option selection question with an unconditional route, that will be fixed in PR #3088.
Things to consider when reviewing