Delete routes to an exit page when that exit page is deleted - #3100
Merged
Merged
Conversation
lfdebrux
force-pushed
the
ldeb-delete-exit-pages-delete-routes
branch
from
September 10, 2026 12:49
4573130 to
c69fdd9
Compare
SamJamCul
previously approved these changes
Sep 10, 2026
Contributor
|
Works as expected and content looks good. |
When an exit page is deleted from the delete action of the exit page controller, any conditions that route to that exit page should also be deleted. We do this in the controller rather than with the `dependent` behaviour of the model itself, because with old-style exit pages (when the multiple branches feature is not enabled) we need to be able to delete the exit page when changing where a condition goes to.
Show a notification banner with a warning informing form creators that routes to an exit page will be deleted when that exit page is deleted. Don't show the notification banner when there is an error summary for validation errors (as per GOV.UK Design System guidance).
lfdebrux
force-pushed
the
ldeb-delete-exit-pages-delete-routes
branch
from
September 11, 2026 14:34
c69fdd9 to
9181e04
Compare
SamJamCul
approved these changes
Sep 11, 2026
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3100.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Make sure conditions that route to an exit page are deleted with the exit page. Also add the warning message to the delete exit page page for this, from the designs in Mural (https://app.mural.co/t/gaap0347/m/gaap0347/1777554146285/b4db73fa35cee565fab61bb4ca050a371393e52f?wid=40-1782227043493).
Things to consider when reviewing