Skip to content

fix: Guard the post-LRO refresh in sandboxes.pause() and sandboxes.resume() on the presence of a resource name in the LRO response. #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 31, 2026
Merged

fix: Guard the post-LRO refresh in sandboxes.pause() and sandboxes.resume() on the presence of a resource name in the LRO response. #7124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions agentplatform/_genai/sandboxes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,14 @@ def pause(
get_operation_fn=self._get_sandbox_operation,
poll_interval_seconds=poll_interval_seconds,
)
if operation.response:
# Only refresh via get() when the LRO response carries a resource
# name. The pause LRO's response_type is declared as SandboxEnvironment
# in the proto but the backend may return an empty payload for some
# code paths, in which case operation.response.name is empty and a
# get() call would produce a 404 with an unsubstituted {name} in the
# request URL. Callers who want the post-pause state can call
# sandboxes.get(name=name) explicitly.
if operation.response and getattr(operation.response, "name", None):
operation.response = self.get(name=operation.response.name)
return operation

Expand Down Expand Up @@ -1084,7 +1091,11 @@ def resume(
get_operation_fn=self._get_sandbox_operation,
poll_interval_seconds=poll_interval_seconds,
)
if operation.response:
# Only refresh via get() when the LRO response carries a resource
# name. Symmetric guard with pause() above: protects against a backend
# response payload without a name field, which would otherwise produce
# a 404 with an unsubstituted {name} in the request URL.
if operation.response and getattr(operation.response, "name", None):
operation.response = self.get(name=operation.response.name)
return operation

Expand Down
Loading