Skip to content

feat(google/cloud/saasplatform/saasservicemgmt/v1): add saasservicemgmt - #14925

Merged
blakeli0 merged 1 commit into
mainfrom
onboard-saasservicemgmt
Nov 4, 2026
Merged

feat(google/cloud/saasplatform/saasservicemgmt/v1): add saasservicemgmt#14925
blakeli0 merged 1 commit into
mainfrom
onboard-saasservicemgmt

Conversation

@zhumin8

@zhumin8 zhumin8 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Onboard google/cloud/saasplatform/saasservicemgmt/v1 API (saasservicemgmt).

Internal tracking bug http://b/581338653

PiperOrigin-RevId: 1012966905

Manual changes

For Java, librarian add google/cloud/saasplatform/saasservicemgmt/v1 derives the library name saasplatform-saasservicemgmt (java.DefaultLibraryName). That name doesn't match the existing saasservicemgmt library, which already contains google/cloud/saasplatform/saasservicemgmt/v1beta1, so add would create a duplicate library and artifact (google-cloud-saasplatform-saasservicemgmt). --name is Ruby-only. Instead, I reverted the add output and added v1 to the existing library by hand, making the same changes add makes for an existing library:

  • librarian.yaml: appended - path: google/cloud/saasplatform/saasservicemgmt/v1 to the saasservicemgmt library's apis:, with java.additional_protos: [google/cloud/location/locations.proto]. This is the mixin that add resolved from the v1 service yaml.
  • versions.txt: added proto-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0 and grpc-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0.

librarian tidy left both edits unchanged; vs main, the librarian.yaml diff is only the added v1 API entry. Everything else in this PR is output from librarian generate.

Note

Review item: librarian generate dropped "rpc_documentation": "https://cloud.google.com/saas-runtime/docs/apis" from java-saasservicemgmt/.repo-metadata.json. It is generator output, not a manual edit.

Debug Info

System Details

  • JDK version: 17.0.20.1 (JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64, the runtime Maven reports and the one it compiled with, via in-process jdk.compiler@17.0.20.1). This JDK 17 install ships no javac binary, so javac -version on PATH reports javac 26.0.2.1.
  • Maven version: Apache Maven 3.9.12
  • OS: Linux 7.1.6-1rodete1-amd64 x86_64
  • Librarian version: v0.51.0

Commands Executed

export JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
export PATH="$JAVA_HOME/bin:$PATH"
export MAVEN_SKIP_RC=true
MAVEN_SKIP_RC=true go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 install
export PATH="$PATH:$HOME/.cache/librarian/bin/java_tools/bin"
go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 add google/cloud/saasplatform/saasservicemgmt/v1
go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 config get libraries google/cloud/saasplatform/saasservicemgmt/v1   # -> saasplatform-saasservicemgmt (see Manual changes)
git checkout -- librarian.yaml versions.txt
# manual edit: append v1 to the saasservicemgmt library's apis in librarian.yaml (see Manual changes)
printf 'proto-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0\ngrpc-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0\n' >> versions.txt
go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 tidy
go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 generate saasservicemgmt
ARTIFACT_ID=$(xmllint --xpath "/*[local-name()='project']/*[local-name()='artifactId']/text()" java-saasservicemgmt/pom.xml 2>/dev/null)   # -> google-cloud-saasservicemgmt-parent
mvn -B -ntp compile -pl ":${ARTIFACT_ID:-google-cloud-saasservicemgmt}" -am   # BUILD SUCCESS (parent pom only)
mvn -B -ntp compile -pl :google-cloud-saasservicemgmt -am   # BUILD SUCCESS (proto/grpc v1 + v1beta1 + client)
go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 tidy
git add .
git commit -m "feat(google/cloud/saasplatform/saasservicemgmt/v1): add saasservicemgmt"

🤖 Opened by an AI agent on behalf of zhumin.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the auto-generated Java client library for the SaaS Service Management API (v1). It includes the gRPC and HTTP/JSON transport stubs, client settings, mock services, and unit tests for the SaasRollouts and SaasDeployments clients. I have no feedback to provide on this pull request.

@zhumin8
zhumin8 marked this pull request as ready for review November 4, 2026 22:03
@zhumin8
zhumin8 requested review from a team as code owners November 4, 2026 22:03
@snippet-bot

snippet-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 180 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@blakeli0
blakeli0 merged commit 8535344 into main Nov 4, 2026
194 checks passed
@blakeli0
blakeli0 deleted the onboard-saasservicemgmt branch November 4, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhumin8 @blakeli0