Skip to content

feat(bigquery-jdbc): add Graph metadata support in getPrimaryKeys method - #14922

Merged
Neenu1995 merged 3 commits into
jdbc/graph-get-columnsfrom
jdbc/graph-get-primary-key
Nov 4, 2026
Merged

feat(bigquery-jdbc): add Graph metadata support in getPrimaryKeys method#14922
Neenu1995 merged 3 commits into
jdbc/graph-get-columnsfrom
jdbc/graph-get-primary-key

Conversation

@Neenu1995

@Neenu1995 Neenu1995 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Neenu1995
Neenu1995 requested review from a team as code owners November 4, 2026 15:12
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements support for retrieving primary keys of property graph elements via the getPrimaryKeys method in BigQueryDatabaseMetaData. It introduces a new SQL template DatabaseMetaData_GetGraphPrimaryKeys.sql to query INFORMATION_SCHEMA.PROPERTY_GRAPHS and routes calls containing a dot in the table name to the new appendGraphPrimaryKeys helper when graph metadata is enabled. Additionally, the PR updates the region scope validation pattern to be lowercase-only and adds corresponding unit and integration tests to verify the functionality. There are no review comments, and I have no feedback to provide.

@Neenu1995
Neenu1995 added this pull request to stack #14909 November 4, 2026 15:22
keshavdandeva
keshavdandeva approved these changes Nov 4, 2026
View reviewed changes

@keshavdandeva keshavdandeva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just nits and suggestion for minor improvement for perf

Comment thread java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java Resolved
Comment thread ...c/src/main/resources/com/google/cloud/bigquery/jdbc/DatabaseMetaData_GetGraphPrimaryKeys.sql Resolved
Comment thread ...c/src/main/resources/com/google/cloud/bigquery/jdbc/DatabaseMetaData_GetGraphPrimaryKeys.sql Resolved
@Neenu1995
Neenu1995 merged commit b3a751f into jdbc/graph-metadata-integration Nov 4, 2026
148 checks passed
@Neenu1995
Neenu1995 deleted the jdbc/graph-get-primary-key branch November 4, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keshavdandeva keshavdandeva keshavdandeva approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Neenu1995 @keshavdandeva