Repository navigation
chore(kokoro): fix IFS bug causing VM timeouts on java8-osx - #14921
Closed
sakthivelmanii wants to merge 2 commits into
Closed
sakthivelmanii wants to merge 2 commits into
sakthivelmanii wants to merge 2 commits into
Conversation
Fixes a Bash 3.2 bug on macOS runners where unset IFS causes mvn to hang.
sakthivelmanii
enabled auto-merge (squash)
November 4, 2026 06:24
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces unset IFS with IFS=$' \t\n' in .kokoro/common.sh to explicitly restore the default field separator. The review feedback suggests declaring IFS as local within the retry_with_backoff function to prevent polluting the global environment.
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces unset IFS with an explicit reset to the default whitespace characters (IFS=$' \t\n') in .kokoro/common.sh. The review feedback recommends declaring IFS as a local variable within the function to prevent polluting the global scope and avoiding unexpected side effects in other parts of the script.
sakthivelmanii
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sakthivelmanii
added
the
kokoro:force-run
auto-merge was automatically disabled
November 4, 2026 15:07
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
common.shrunner script unsetsIFSwhich triggers a shell bug in older macOS Bash (3.2.57) leading to infinite loops or timeouts (10800 seconds) inmvn install.Solution
Replace
unset IFSwithIFS=$' \t\n'to safely reset the field separator without triggering the unset bug in Bash 3.2.