Repository navigation
chore(bigtable): skip server polling on client-config-override and add override-use-default property - #14908
Open
igorbernstein2 wants to merge 2 commits into
Open
chore(bigtable): skip server polling on client-config-override and add override-use-default property#14908igorbernstein2 wants to merge 2 commits into
igorbernstein2 wants to merge 2 commits into
Conversation
… override-use-default property
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new system property bigtable.internal.client-config-override-use-default to control whether local client configuration overrides are merged on top of the default configuration or used as-is. When a local override is present, the ClientConfigurationManager now avoids creating a gRPC channel and polling the server, returning the local configuration immediately. The tests have been updated and expanded to verify these behaviors. I have no further feedback to provide as there are no review comments.
igorbernstein2
changed the title
mutianf
approved these changes
Nov 3, 2026
… sys props in ClientConfigurationManager
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
bigtable.internal.client-config-overrideis set, use the parsedClientConfigurationlocally and skip polling the server instead of merging the override on top of server responses.Also adds
bigtable.internal.client-config-override-use-default, which whentruemergesbigtable.internal.client-config-overrideon top of the bundled defaultClientConfiguration(bigtable-default-client-config.textproto).