feat(opentelemetry): support OpenTelemetry v1.28.0 by colinmoy · Pull Request #16453 · googleapis/google-cloud-cpp

colinmoy · 2026-09-15T18:19:26Z

No description provided.

gemini-code-assist

Code Review

This pull request upgrades the opentelemetry-cpp dependency to version 1.28.0 across Bazel configurations, Dockerfiles, and documentation. However, the review identified a major regression where a large portion of doc/packaging.md (including the introduction, macOS instructions, and footnotes) was accidentally deleted. Additionally, the changes in grpc_opentelemetry.cc and its test file introduce commented-out code as inline annotations; these should be replaced with clean, raw string literals, and sc::rpc::kRpcMethod should be updated to "rpc.method" for consistency.

dbolduc

I think we lost some of doc/packaging.md, but otherwise LG

dbolduc · 2026-09-15T18:20:24Z

@@ -1,140 +1,3 @@
-# Packaging `google-cloud-cpp`


restore this?

dbolduc · 2026-09-15T18:21:03Z


 </details>

-<!-- inject-distro-instructions-end -->


scotthart · 2026-09-15T18:56:05Z

Other than the dockerfiles I called out to update to v1.28.0, let's revert the others to their current values.

codecov · 2026-09-15T20:03:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.31%. Comparing base (4955812) to head (c1e44e4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16453      +/-   ##
==========================================
+ Coverage   92.29%   92.31%   +0.01%     
==========================================
  Files        2246     2246              
  Lines      213751   213751              
==========================================
+ Hits       197290   197326      +36     
+ Misses      16461    16425      -36

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

scotthart · 2026-09-16T14:25:12Z

Looks like the new version of otel changed a parameter from pass by value, to pass by const ref.

Removed Symbols  1 

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
recordable.h
namespace opentelemetry::v1::sdk::trace
Recordable::AddLink ( opentelemetry::v1::trace::SpanContext p1 )
_ZN13opentelemetry2v13sdk5trace10Recordable7AddLinkENS0_5trace11SpanContextE


to the top

Problems with Symbols, Medium Severity  1 

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
recordable.h
namespace opentelemetry::v1::sdk::trace
[+] Recordable::AddLink ( opentelemetry::v1::trace::SpanContext p1 )  1 
⇣
Recordable::AddLink ( opentelemetry::v1::trace::SpanContext const& p1 )
_ZN13opentelemetry2v13sdk5trace10Recordable7AddLinkENS0_5trace11SpanContextE

              Change                                 Effect
1 Parameters list has been        Recompilation of a client program may be
  changed.                        broken.

While technically breaking, this should be compatible. Update the abi dump for our google_cloud_cpp_opentelemetry library and the check should pass.

scotthart · 2026-09-15T18:34:50Z

 bazel_dep(name = "platforms", version = "1.1.0")
 bazel_dep(name = "bazel_skylib", version = "1.9.2")
-bazel_dep(name = "rules_cc", version = "0.2.17")
+bazel_dep(name = "rules_cc", version = "0.2.22")


We should make this change in a separate PR. I think renovate-bot may already have one in flight.

scotthart · 2026-09-15T18:35:11Z

 bazel_dep(name = "nlohmann_json", version = "3.12.0.bcr.1")
 bazel_dep(name = "curl", version = "8.8.0.bcr.3")
-bazel_dep(name = "opentelemetry-cpp", version = "1.24.0")
+single_version_override(


This seems redundant.

scotthart · 2026-09-15T18:51:52Z

+    module_name = "curl",
+    version = "8.8.0.bcr.3",
+)
+bazel_dep(name = "opentelemetry-cpp", version = "1.28.0")


As this file specifies recommended minimum versions, let's keep it a 1.24.0.

scotthart · 2026-09-15T18:52:46Z


 WORKDIR /var/tmp/build/
-RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.24.0.tar.gz | \
+RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.28.0.tar.gz | \


Let's keep this at v1.28.0 since our clang-tidy builds use it.

scotthart · 2026-09-15T18:53:08Z


 WORKDIR /var/tmp/build/
-RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.24.0.tar.gz | \
+RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.28.0.tar.gz | \


Let's keep this one also at 1.28.0 to sniff out any C++20 issues.

scotthart · 2026-09-15T18:54:00Z

        name = "opentelemetry-cpp",
        urls = [
-            "https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.20.0.tar.gz",
+            "https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.28.0.tar.gz",


Let's revert this to 1.20.0 to make sure we work with the old semantic conventions and because our bazel oldest builds uses WORKSPACE files.

scotthart · 2026-09-16T14:30:49Z

-      {{sc::rpc::kRpcSystem, sc::rpc::RpcSystemValues::kGrpc},
-       {sc::rpc::kRpcService, service},
-       {sc::rpc::kRpcMethod, method},
+      {{"rpc.system", sc::rpc::RpcSystemValues::kGrpc},


Revert these changes. Going from a strongly typed enums to a string literals is backwards. It turns a potential compilation error in to a runtime error.

scotthart · 2026-09-16T14:30:57Z

          SpanNamed("google.cloud.foo.v1.Foo/GetBar"),
          SpanHasAttributes(
-              OTelAttribute<std::string>(sc::rpc::kRpcSystem,
+              OTelAttribute<std::string>("rpc.system",


Revert these changes. Going from a strongly typed enums to a string literals is backwards. It turns a potential compilation error in to a runtime error.

feat(opentelemetry): support OpenTelemetry v1.28.0

29c8f45

colinmoy requested a review from a team as a code owner September 15, 2026 18:19

colinmoy deployed to false September 15, 2026 18:19 — with GitHub Actions Active

gemini-code-assist Bot reviewed Sep 15, 2026

View reviewed changes

Comment thread doc/packaging.md

Comment thread google/cloud/internal/grpc_opentelemetry.cc Outdated

Comment thread google/cloud/internal/grpc_opentelemetry_test.cc Outdated

dbolduc reviewed Sep 15, 2026

View reviewed changes

address review comments

bda8a69

colinmoy deployed to false September 15, 2026 22:01 — with GitHub Actions Active

Merge branch 'main' into feat-opentelemetry-1-28-0

c1e44e4

colinmoy deployed to false September 15, 2026 22:38 — with GitHub Actions Active

scotthart requested changes Sep 16, 2026

View reviewed changes

Uh oh!

Conversation

colinmoy commented Sep 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbolduc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scotthart commented Sep 15, 2026

Uh oh!

codecov Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

scotthart commented Sep 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Sep 15, 2026 •

edited

Loading