Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 20 20
Lines 6429 6429
=======================================
Hits 5956 5956
Misses 473 473 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdbe9811f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| clippy::all, | ||
| clippy::cargo, | ||
| clippy::pedantic, | ||
| clippy::nursery, | ||
| clippy::restriction, |
There was a problem hiding this comment.
When a downstream crate runs Clippy and forbids any lint contained in one of these groups—for example, #![forbid(clippy::needless_borrow)]—the generated #[allow(clippy::all)] attempts to lower that forbidden lint and produces E0453 at every derive expansion; the same applies to members of the cargo, pedantic, nursery, and restriction groups. Consequently, strict consumers that previously compiled can no longer use any derive even when the expansion does not trigger their forbidden lint. Keep emitted suppressions targeted to concrete generated-code violations, or make those expansions lint-clean, rather than lowering blanket groups.
AGENTS.md reference: zerocopy/AGENTS.md:L49-L50
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Restore the targeted generated-code Clippy allowance and keep the #3721 regression test at deny rather than forbid.
This branch has not been deployed
2 participants
Follow up on #3721 and #3722 by making Clippy validation of derive-generated code explicit.
Zerocopy CI now compiles
zerocopy-deriveintegration tests in an internal mode that deniesclippy::all,clippy::pedantic, andclippy::nurseryon generated-only scopes. We intentionally do not enableclippy::restrictionwholesale because that group is policy-specific and contains mutually incompatible lints.This group-level lint mode is CI-only and is not emitted in normal downstream expansions. Existing targeted generated-code allowances remain in place where needed.
The #3721 regression integration test continues to deny
clippy::derive_partial_eq_without_eq, checking downstream behavior under the existing lint policy without claiming compatibility withforbid(...).The existing nightly
cargo clippy --testsmatrix enables internal lint mode forzerocopy-derive, covering all integration-test targets selected by Cargo. A separate nightly x86_64 check compiles the #3721 fixture in normal downstream mode.Caller-authored invariant expressions retain the caller's lint policy; generated-code lint attributes remain outside those mixed scopes. Two nursery lints about duplicate bounds are excluded only from internal generated-code checking because they diagnose caller-authored bounds copied verbatim into generated impls; the caller's own declaration remains subject to the caller's lint policy.
Authored by an AI agent acting on joshlf's behalf.