Repository navigation
Jetbrains teamcity CVE 2023 42793 - #930
Open
robert-doyensec wants to merge 6 commits into
Open
robert-doyensec wants to merge 6 commits into
robert-doyensec wants to merge 6 commits into
Conversation
…_CVE_2023_42793.textproto Co-authored-by: Giacomo Coluccelli <giacomo@doyensec.com>
…_CVE_2023_42793.textproto Co-authored-by: Giacomo Coluccelli <giacomo@doyensec.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the TeamCity Auth Bypass RCE (CVE-2023-42793) detector from its original Java implementation to the new templated format (.textproto), deleting the old Java source, build, and test files. Feedback on the changes highlights two main issues: first, the delete_existing_token action should explicitly allow 404, 200, and 204 status codes to prevent workflow failures on clean TeamCity instances where the token does not yet exist; second, the README link to the new .textproto file should use /blob/master/ instead of /tree/master/ to avoid a broken link.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testbed is at google/security-testbeds#280