Repository navigation
Spring cloud gateway CVE 2022 22947 - #279
Open
robert-doyensec wants to merge 2 commits into
Open
robert-doyensec wants to merge 2 commits into
robert-doyensec wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a Docker Compose setup and a Spring Boot application to demonstrate CVE-2022-22947 (a SpEL injection vulnerability in Spring Cloud Gateway). It includes a vulnerable service and a patched service for comparison, along with a README detailing how to reproduce the vulnerability. A review comment points out that the spring-boot-maven-plugin is declared twice in the pom.xml file and suggests merging them into a single configuration.
Comment on lines
+45
to
+55
| <plugin> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-maven-plugin</artifactId> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-maven-plugin</artifactId> | ||
| <configuration> | ||
| <mainClass>com.example.demo.Application</mainClass> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
The spring-boot-maven-plugin is declared twice in the <plugins> block. These duplicate declarations should be merged into a single plugin configuration to keep the POM file clean and maintainable.
<plugin>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-maven-plugin</artifactId>
<configuration>
<mainClass>com.example.demo.Application</mainClass>
</configuration>
</plugin>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.