Rename get_cpu_arch to get_target_cpu_arch - #5464
Draft
JuanMBriones wants to merge 1 commit into
Draft
JuanMBriones wants to merge 1 commit into
JuanMBriones wants to merge 1 commit into
Conversation
JuanMBriones
force-pushed
the
rename_get_cpu_arch
branch
from
September 11, 2026 08:29
e094843 to
cc8580a
Compare
g-ortuno
requested changes
Sep 11, 2026
JuanMBriones
force-pushed
the
rename_get_cpu_arch
branch
2 times, most recently
from
September 14, 2026 22:31
a9768d0 to
c6aea43
Compare
JuanMBriones
commented
Sep 14, 2026
| return get_host_cpu_arch() | ||
|
|
||
|
|
||
| def get_host_cpu_arch(): |
JuanMBriones
force-pushed
the
rename_get_cpu_arch
branch
from
September 14, 2026 22:35
c6aea43 to
fc8d6fc
Compare
`get_cpu_arch` method might be a bit confusing, `get_target_cpu_arch` is a bit more descriptive. - Ran `python butler.py py_unittest -t core -p commands_test.py` (passed). - Ran `python butler.py py_unittest -t core -p settings_test.py` (passed). - Ran `python butler.py py_unittest -t core -p environment_test.py` (passed). Bug: 559993851 Signed-off-by: Manuel Briones <manuelbriones@google.com>
JuanMBriones
force-pushed
the
rename_get_cpu_arch
branch
from
September 14, 2026 22:37
fc8d6fc to
ef7abd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_cpu_archmethod might be a bit confusing,get_target_cpu_archis a bitmore descriptive.
python butler.py py_unittest -t core -p commands_test.py(passed).python butler.py py_unittest -t core -p settings_test.py(passed).python butler.py py_unittest -t core -p environment_test.py(passed).Bug: 559993851
Signed-off-by: Manuel Briones manuelbriones@google.com