Skip to content

Fix radamsa binary for ARM64 - #5463

Draft
JuanMBriones wants to merge 1 commit into
masterfrom
mac_arm64_coverage_guided_fuzzers_support_extra_deps
Draft

JuanMBriones wants to merge 1 commit into
masterfrom
mac_arm64_coverage_guided_fuzzers_support_extra_deps

Conversation

@JuanMBriones

@JuanMBriones JuanMBriones commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

When executing Mac ARM64 swarming tasks we execute radamsa binary,
hence having it as a ARM64 is needed.

  • Ran python butler.py py_unittest -t core -p engine_common_test.py (passed).

Bug: 561690132

@JuanMBriones
JuanMBriones requested a review from a team as a code owner September 9, 2026 02:18
@JuanMBriones
JuanMBriones marked this pull request as draft September 9, 2026 02:18
@JuanMBriones JuanMBriones changed the title wip: Fix radamsa binary for ARM64 Fix radamsa binary for ARM64 Sep 11, 2026
@JuanMBriones
JuanMBriones added this pull request to stack #5469 September 11, 2026 19:47
@JuanMBriones
JuanMBriones force-pushed the mac_arm64_coverage_guided_fuzzers_support_extra_deps branch 3 times, most recently from c8b03ac to 4f3a08a Compare September 14, 2026 23:07
When executing macOS ARM64 Swarming tasks, ClusterFuzz invokes the radamsa mutator binary. Previously, only an x86_64 macOS binary was bundled, and extracted files could lack execute permissions under Swarming bot users.

Changes:
* Add native macOS ARM64 binary (`bin/mac/radamsa_arm64`).
* Update `get_radamsa_path()` in `engine_common.py`:
  - Prefer `radamsa` from `APP_DIR` (fuzzer build directory) if present.
  - Detect ARM64 on macOS and select `radamsa_arm64` over x86_64 `radamsa`.
  - Ensure `0o755` permissions on the resolved binary via `os.chmod`.
* Add unit tests for `get_radamsa_path()` in `engine_common_test.py`.

Bug: 561690132
Signed-off-by: Manuel Briones <manuelbriones@google.com>
@JuanMBriones
JuanMBriones force-pushed the mac_arm64_coverage_guided_fuzzers_support_extra_deps branch from 4f3a08a to 2be786f Compare September 15, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant