[Android] Refine bad build check and testcase manager execution

[IvanBM18]

Bug: b/553141628

Overview

Since Android API level 30 (and apps targeting Android 11+), apps have scoped storage access. Previously, bad build checks for Android did not verify whether the application process actually survived startup because am start returns 0 even if the process dies immediately.

This PR enhances check_for_bad_build() in testcase_manager.py by ensuring command line files are written prior to execution and flipping a conditional so in the bad build check the android specific validation proceeds other validations.

The later was required because thanks to this PR we added the possibility to check for false positives, but this added a problem in which valid builds were incorrectly flagged as crashes, so by flipping the conditional we fix this.

Changes

• src/clusterfuzz/_internal/bot/testcase_manager.py: Updated check_for_bad_build() to pass write_command_line_file=True and verify target application process presence on Android post-launch.

Tests performed

Basically the same as the parent PR

• Tested them in swarming: https://chrome-swarming.appspot.com/task?id=7a8188fe65a42510
• Tested them locally using an avd device against an invalid apk, that is the previous iteration of our chrome public apk, the apk returned the following:

reason=2 (SIGNALED) subreason=0 (UNKNOWN) status=9

When this happen now CF correctly determines that the app crashed due to runtime issues not related to memory errors.

PR stack

• master
  • #PR 2.1a feature/android-exit-code-constants
  • #PR 2.1b feature/android-exit-code-core
  • #PR 2.2 feature/android-exit-code-process-handler
  • #PR 2.3 feature/android-bad-build-check 👈

Note:

Adding additional debug logs in this other PR:

• [Android] Adding debug logs #5461

[dylanjew]

LGTM. sorry, forgot to send my comments earlier

[decoNR]

Overall LGTM. Left a quick question, please answer it before merging.

Were you able to test it in dev to guarantee that this does not affect other platforms? I think this seems important since one of the changes is not specific to Android.

[IvanBM18]

Overall LGTM. Left a quick question, please answer it before merging.

Were you able to test it in dev to guarantee that this does not affect other platforms? I think this seems important since one of the changes is not specific to Android.

Sure no worries, that specific argument in the

get_command_line_for_application()

Is only used on android, see:

• https://github.com/google/clusterfuzz/blob/master/src/clusterfuzz/_internal/bot/testcase_manager.py#L1137

[decoNR]

Overall LGTM. Left a quick question, please answer it before merging.
Were you able to test it in dev to guarantee that this does not affect other platforms? I think this seems important since one of the changes is not specific to Android.

Sure no worries, that specific argument in the

get_command_line_for_application()

Is only used on android, see:

• https://github.com/google/clusterfuzz/blob/master/src/clusterfuzz/_internal/bot/testcase_manager.py#L1137

Perfect, thanks.