Repository navigation
fix(dashboard): preact 10/11-compatible style prop type - #107
Merged
Merged
Conversation
…act 10 and 11 JSX.CSSProperties is removed from the JSX namespace in preact 11 (CSSProperties moves to the package root), which fails astro check in the dependabot all-js-deps group bump. IntrinsicElements["div"]["style"] resolves on both majors. Refs #103
FumingPower3925
marked this pull request as ready for review
October 19, 2026 10:31
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Merging with every required check green (build, coverage, CodeQL, codecov/patch, Workers Builds). The CodeRabbit review is advisory and had not finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #103
JSX.CSSPropertiesno longer exists in preact 11, soastro checkfails onIcons.tsxandPanel.tsxin the dependabot group bump (#103). Typing the prop asJSX.IntrinsicElements["div"]["style"]is identical in effect and resolves on both preact 10.29.8 and 11.0.1.Verified locally:
bun run check(0 errors),bun run build,bun test(22 pass) on both preact 10.29.8 (main lockfile) and 11.0.1 (#103 manifest and lockfile). No runtime change.