Skip to content

v1.6.0 polish: documentation #891

Open

Description

@FumingPower3925

Consolidated on 2026-10-02 from the per-PR 'Follow-ups from #N' bundles, by maintainer decision. From now on, review nits are fixed inside the PR before it merges, so no new bundles are filed. Each line names the bundle and item it came from; the bundle's thread keeps the full context. Everything here stays in v1.6.0.

Activity

  1. added this to the v1.6.0 milestone on Oct 2, 2026
  2. FumingPower3925 commented on Oct 3, 2026

    @FumingPower3925
    ContributorAuthor

    For the item "State the post-#805 memory bound in docs/godoc: an HTTP/2 conn may queue 64 MiB before a refused write ... (from #818 1a)": the HTTP/2 half changes with the fix for #893, #906 (stacked on #900).

    So the docs sentence, once the fix merges, can read: an HTTP/2 connection holds at most 64 MiB in its socket send queue and about 4 MiB (plus one response body) in its streams' buffers for a peer that grants no window; a StreamWriter response is the exception until #904.

  3. FumingPower3925 commented on Oct 3, 2026

    @FumingPower3925
    ContributorAuthor

    Correction and two more items from the round-1 review of #906 (celeris#893, lane F3). The first one replaces the docs sentence that issuecomment-5964016328 proposed.

  4. FumingPower3925 commented on Oct 3, 2026

    @FumingPower3925
    ContributorAuthor

    One item from lane MW (PR #920, celeris#732/#742):

    Added after #920's and #918's round-1 reviews (lines at docs main 30f9bcc):

  5. FumingPower3925 commented on Oct 3, 2026

    @FumingPower3925
    ContributorAuthor

    Item 27 (the FullPath sentinels), from lane SW's review of #916 (correctness lens r1, NIT): add goceleris/docs src/content/docs/performance.md:74, which says "FullPath() returns "" when no route matched (e.g. inside a custom NotFound handler)"; it returns "<unmatched>" there (handler.go sets c.fullPath before the chain).

    Every site but the otel one is fixed in the PRs now, so the item can be ticked when they merge:

  6. FumingPower3925 commented on Oct 3, 2026

    @FumingPower3925
    ContributorAuthor

    One more item from lane MW, after #920's round-2 review (lines at docs main a8db30b):

  7. FumingPower3925 commented on Oct 4, 2026

    @FumingPower3925
    ContributorAuthor

    Added 2026-10-04: found while preparing goceleris/docs#92 (the #443 move's docs pass)

    These docs inaccuracies predate the move and are outside #92's scope.

  8. FumingPower3925 commented on Oct 9, 2026

    @FumingPower3925
    ContributorAuthor

    PR #972 (draft) covers items 2a (the IfRange godoc) and 2b (middleware/static/doc.go; the docs page is goceleris/docs#96). Item 6: the docs main already uses os.OpenRoot and a content-derived ETag note in the Range example, so nothing is left there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions