Skip to content

test: TestNICIRQReportAddsNoLoop1036 can read the log before Listen logs 'listening' (start909 returns on the published address) #1108

Closed

Description

@FumingPower3925

TestNICIRQReportAddsNoLoop1036 (internal/engine/epoll) failed in CI twice (the first CI run of PR #1106 and attempt 2 of PR #1105's Coverage): the start909 helper returns as soon as the engine has published its address, but Listen logs "listening" after that, so the test can read the log before the line is there.

Fix: celeris draft PR #1106 makes start909 return only once the listening line is logged, with a failing-first test (TestStart909ReturnsOnlyOnceTheListeningLineIsLogged: 5 of 5 red before, 30 of 30 green after). The test exercises the helper's ordering; no natural reproduction was seen locally (0 of 100). Found while triaging the CI flakes of PR #1105.

Activity

  1. added this to the v1.6.0 milestone on Oct 25, 2026
  2. FumingPower3925 commented on Oct 29, 2026

    @FumingPower3925
    ContributorAuthor

    Fixed by #1106 (merged 2026-10-25), verified by failing-first reproduction in the review of the flake lane: the fix reverted fails the regression test 20 of 20, the merged tree passes 20 of 20 (#1068 epoll async closing response truncation: product bug; #1107 and #1108: test bugs). No recurrence in the CI runs since the merge. Refs #1106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions