Repository navigation
feat(log): timestamp activity log entries - #260
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prefix every activity log line with an RFC 3339 timestamp inside
LogBuffer::append, before redaction and storage. The clock is injectable for tests, andglib::DateTime::now_local()supplies local time with its numeric offset, with a UTCZfallback.Why
The daily log preserved event order but not when each event happened. Correlating it with the system journal during startup diagnoses required guessing. Closes #259.
Verification
cargo test --lib core::log: 13 passedcargo test --lib: 739 passed, 0 failed, 1 ignoredcargo clippy --all-targets -- -D warnings: cleancargo fmt --all -- --check: clean