Skip to content

[dashboard-language] Reactive core - #80

Merged
pelikhan merged 3 commits into
mainfrom
dashboard-reactive-core-6bc299cde3a80a71
Aug 28, 2026
Merged

[dashboard-language] Reactive core#80
pelikhan merged 3 commits into
mainfrom
dashboard-reactive-core-6bc299cde3a80a71

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Caution

Protected files were modified in this change.
This pull request is in request_review mode and requires explicit human scrutiny before merge.

Protected files: README.md, package-lock.json, package.json

Milestone

Reactive core

Specification coverage

  • Target architecture slice: tiny reactive core inspired by VanJS
  • Verified behavior for state, derived values, effects, disposal, and keyed list reconciliation
  • Requirement identifiers covered by tests in this increment:
    • DLS-CONF-004

What shipped

  • Added pages/dashboard/src/reactive.js with deterministic reactive state, derived values, effect reruns, and disposal.
  • Added pages/dashboard/src/dom.js with a small hyperscript-style DOM builder, attribute/dataset handling, and keyed list reconciliation supporting updates, removals, and reordering.
  • Added unit tests for state updates, derived recomputation, effect disposal, DOM creation, and keyed list behavior.
  • Added a browser e2e spec covering stable keyed rendering in the browser harness.
  • Updated pages/dashboard/PLAN.md and pages/dashboard/README.md for the shipped slice.

Quality gates

  • npm install
  • npm run typecheck
  • npm run lint
  • npm test
  • npm run test:e2e ⚠️ blocked by infrastructure

Blockers

  • Playwright browser launch is blocked in this runner because the Chromium executable is not installed (browserType.launch: Executable doesn't exist). The e2e tests are present, but browser execution could not be completed in this environment.

Next milestone

Document model and validation

Generated by 🧩 Daily Dashboard Language Renderer · pi · gpt54 · 26.8 AIC · ⌖ 12.3 AIC · ⊞ 5.2K ·

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protected files were modified in this pull request and require manual scrutiny before merge.

Please verify that each protected-file change is intentional, policy-compliant, and safe:

  • Protected files: README.md, package-lock.json, package.json

@pelikhan
pelikhan marked this pull request as ready for review August 28, 2026 11:22
@pelikhan

Copy link
Copy Markdown
Contributor

@copilot fix infrastructure issues with playwright (use MCP instead of playwright-cli)

@pelikhan

Copy link
Copy Markdown
Contributor

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@copilot fix infrastructure issues with playwright (use MCP instead of playwright-cli)

Updated the dashboard renderer to use the built-in Playwright MCP browser tooling instead of the incompatible playwright-cli flow, and aligned the plan/test expectation with that runtime. Verified with the targeted workflow contract test: node --test --test-name-pattern='daily dashboard renderer builds incrementally inside its own directory' tests/unit/workflow-contract.test.mjs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@copilot fix https://github.com/githubnext/central-agentic-ops/actions/runs/33166469178/job/98834496735#step:9:1

Fixed the failing browser check by loading the actual DOM source through a data-URL module import instead of a file:// import from about:blank, which was causing the heading not to render in Playwright. Verified with: cd /home/runner/work/central-agentic-ops/central-agentic-ops/pages/dashboard && npx playwright test test/e2e/reactive-core.spec.js --config=playwright.config.mjs (pass, 1/1). Commit: 7302fad.

@pelikhan
pelikhan merged commit 64f1559 into main Aug 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants