Skip to content

fix #318 some countourviews not round in stand astig removal - #410

Merged
gr5 merged 1 commit into
masterfrom
JST/fix318
Nov 17, 2026
Merged

gr5 merged 1 commit into
masterfrom
JST/fix318

Conversation

@atsju

@atsju atsju commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

Removed manual 80% scaling from historical code (that was used to fit specific screens best effort round).
Reordered some resize and render functions to scale correctly automatically.

fix #318

@atsju
atsju requested review from githubdoe and gr5 November 8, 2026 08:37
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

🚀 New build available for commit 648048b
Download installer here

@gr5

gr5 commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

@githubdoe - do you remember what all those "* 0.8" are for? I'm thinking it was related to creating the pdf file. Julien, the proper testing would including outputting it into a pdf file to make sure it all fits on the page and none of the plots get cropped as they did in the past.

Unfortunately, this is one of those issues (pdf crops images) where it works one way for 99% of us and another way for Dale if he builds in QT5. This particular issue might not be a QT5/QT6 issue but I think might be an issue when windows scaling is set to 225%.

I tested just now using the link above and the pdf report looks great.

@gr5 gr5 changed the title fix #318 some countourviews not round in stad astig removal fix #318 some countourviews not round in stand astig removal Nov 12, 2026
@gr5

gr5 commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

I'm going to do a little more testing but I think this PR is probably good.

@gr5 gr5 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and asked Dale about the 0.8. He said it was to improve the pdf. I tried manually adding the 0.8s back in. It did not help the pdf report. I tried both with my normal resolution and I tried it at 4K pixels screen width with GUI scaling at 225% (which is how Dale's laptop is) and with QT6. There is no improvement with the 0.8 so I approve this PR.

This PR definitely makes the circles round.

I was also nervous about the deleted "setSurface" commands but I checked each image carefully. I created very distinctive wavefronts with the simulator and was able to prove that every image is correct in both the 3 pages of output and the pdf.

So I approve this PR. It is an improvement. The images at 4k 225% are annoyingly small. But it's no worse than before this PR. And the images are great at 100% scaling on my desktop.

@gr5
gr5 merged commit a38156b into master Nov 17, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This one contour view not round - in test stand astig removal

2 participants