Repository navigation
Conversation
Related to #405.
|
🚀 New build available for commit |
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v21.1.8
✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback
|
🚀 New build available for commit |
|
Interesting. I have a set of 62 curated igrams with actual circle locations (and some of them have an inner circle as well and some have laser dots regioned as well). I was planning to use actual igrams taken by humans as the input to any testing. You went with code to generate the data with software. Maybe you could add some random numbers to the data as well. Perhaps with a seed so the randomness is consistent from one test to the next. I take issue with how DFTF processes the igram before the data even gets to the CircleFitByHyper() function. So I'm not sure how useful it is to write a test for just this one function. But certainly not useless! I've seen little typo-like bugs in DFTF before that went un-noticed until I found them. They made only a small difference in the scheme of things but they did mess up the data a little bit. Perhaps this type of test could lead us to similar bugs. |

Related to #405.
This could be a first seed to Unit tests