Skip to content

add standalone circle-fit tests - #407

Open
atsju wants to merge 2 commits into
masterfrom
JST/circlefit-tests
Open

atsju wants to merge 2 commits into
masterfrom
JST/circlefit-tests

Conversation

@atsju

@atsju atsju commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Related to #405.
This could be a first seed to Unit tests

@atsju
atsju requested review from githubdoe and gr5 November 5, 2026 12:41
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

🚀 New build available for commit 37213b8
Download installer here

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v21.1.8


✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback

Comment thread tests/tst_circlefit.cpp Resolved
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

🚀 New build available for commit b31d187
Download installer here

@gr5

gr5 commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Interesting. I have a set of 62 curated igrams with actual circle locations (and some of them have an inner circle as well and some have laser dots regioned as well).

I was planning to use actual igrams taken by humans as the input to any testing.

You went with code to generate the data with software. Maybe you could add some random numbers to the data as well. Perhaps with a seed so the randomness is consistent from one test to the next.

I take issue with how DFTF processes the igram before the data even gets to the CircleFitByHyper() function. So I'm not sure how useful it is to write a test for just this one function. But certainly not useless! I've seen little typo-like bugs in DFTF before that went un-noticed until I found them. They made only a small difference in the scheme of things but they did mess up the data a little bit. Perhaps this type of test could lead us to similar bugs.

@atsju

atsju commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

You are describing unit test VS integration test.

image

Both are useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants