Fix .NET in-process callback lifetime - #2397
Draft
minyitang wants to merge 1 commit into
Draft
Conversation
Use tracked runtime connections and drain callbacks before releasing managed callback state. Preserve force-stop latency by retaining callback state when an immediate drain cannot complete. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b659bb88-f59c-49d3-afa7-c1b38d575f4b
Contributor
Cross-SDK Consistency Review ✅This PR makes internal implementation changes to the .NET FFI layer (
No cross-SDK consistency issues found. Specifically:
This is a valid language-specific internal fix.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForceStopAsyncbehavior with an immediate close that safely retains callback state when necessaryGCHandle, matching the modern .NET lifetime guaranteeCompatibility
This is stacked on #2390 because
copilot_runtime_connection_open_trackedandcopilot_runtime_connection_close_and_waitare available in the bundled runtime starting with CLI1.0.81-7; #2390 updates the SDK to1.0.81-9.Validation
net8.0,net10.0, andnetstandard2.0with zero warningsdotnet format --verify-no-changespassed