Kotlin: Fix findTopLevelPropertyOrWarn for K2 compiler

[david-allison]

Note

Assisted-by: Claude Opus 4.8 - diagnostics & initial fix

• Fixes False positive "use of implicit PendingIntents" alert #20153 (1/2 bugs)
  • Either bugfix fix would close the issue
  • K2 also broke or PendingIntent.FLAG_IMMUTABLE - see the issue for more details
• Fixes https://github.com/ankidroid/Anki-Android/security/code-scanning/35
• Mirrors Kotlin: Fix findTopLevelFunctionOrWarn for Kotlin 2 #14835

---

Receiver::class.java resolves differently from K1:

• K1: getJavaClass(KClass) - value argument
• K2: KClass.<get-java>() - property receiver

This caused the lookup to fail, so Intent(context, Receiver::class.java) dropped the second argument.

"Couldn't find JVM intrinsic property kotlin.jvm java in kotlin.jvm.JvmClassMappingKt"

This caused false positives in java/android/implicit-pendingintents

[andersfugmann]

Thanks for submitting
The approach and solution is sound and looks good. Also thanks for adding tests.

I added one comment on making the filter slightly more readable.

If you could address that comment and rebase on latest main, this will be good to merge.

[david-allison]

I added one comment on making the filter slightly more readable.

Hi @andersfugmann, thanks for the review. I don't see your comment in the GitHub UI, could you send a link? (Presumably for KotlinFileExtractor.kt‎, but I'd want to be certain).

I'll try and get to this before the weekend. Thanks again

[andersfugmann]

If I understand correctly, the problem is that K2 in some cases the parent is not an IrClass but an IrExternalPackageFragment, in which case we need to access the name through call to getFileClassFqName. If so, I think it will be more readable by using a pattern match on the type if parent node, e.g:

    .firstOrNull {
        val owner = it.owner
        when (val parent = owner.parent) {
            is IrClass -> parent.fqNameWhenAvailable?.asString()
            is IrExternalPackageFragment -> getFileClassFqName(owner)?.asString()
            else -> null
        } == type
    }

[david-allison]

Done, cheers!

[andersfugmann]

My bad. Forgot to submit the comment :-)