Pre-release 0.51.182 - #931
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
Core/Sources/ChatService/ToolCalls/ClientToolConfirmationEventHandler.swift — Enforce the current auto-approval feature flag and policy before using this cached approval. Both… |
What changed in this PR
Updates the Copilot language server and adds session-scoped auto-approval for webpage URLs.
Changes:
- Bumps language server packages to 1.537.0.
- Adds URL extraction, storage, approval checks, and cleanup.
- Adds confirmation UI and unit tests.
| File | Description |
|---|---|
Server/package.json |
Updates language server dependencies. |
Server/package-lock.json |
Locks updated packages and transitive dependencies. |
Core/Tests/ChatServiceTests/ToolAutoApprovalParsingHelpersTests.swift |
Tests URL approval behavior. |
Core/Sources/ConversationTab/Views/ConversationAgentProgressView/ConversationAgentProgressView.swift |
Adds webpage approval UI. |
Core/Sources/ChatService/ToolCalls/ClientToolConfirmationEventHandler.swift |
Checks stored URL approvals. |
Core/Sources/ChatService/ToolCalls/AutoApproval/ToolAutoApprovalParsingHelpers.swift |
Extracts and normalizes URLs. |
Core/Sources/ChatService/ToolCalls/AutoApproval/ToolAutoApprovalManager.swift |
Manages webpage approvals. |
Core/Sources/ChatService/ToolCalls/AutoApproval/FetchWebPageApprovalStorage.swift |
Stores approvals by conversation. |
Files not reviewed (1)
- Server/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+61
to
+65
| if ToolAutoApprovalManager.isFetchWebPageOperation(name: params.name) { | ||
| let urls = ToolAutoApprovalManager.extractFetchWebPageURLs(from: params.input) | ||
| let allowed = await ToolAutoApprovalManager.shared.isFetchWebPageAllowed( | ||
| conversationId: params.conversationId, | ||
| urls: urls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated release PR.