Skip to content

doctor does not see lock files, store permissions or hooks: the three operational failure modes found by the audit all report healthy #75

Description

@flyingrobots

A stale refs/locks/jobs/*.lock, a store directory the caller cannot write, and an executable hooks/reference-transaction each make writers fail or run foreign code, and doctor reports healthy for all three; it also reports path-ref-stray for a record that failed to decode, a finding that is spurious because the paths could not be read. Add checks for lock files, write permission, hooks and core.hooksPath, and suppress dependent checks after record-decodes fails.

Source: docs/audit/2026-10-02_ship-readiness-audit.md SHIP-01, SHIP-05, SHIP-10, docs/audit/2026-10-02_day-0-dx-audit.md DX-15 at a5c0acd; lib/175-doctor.sh.

Activity

  1. flyingrobots commented on Oct 5, 2026

    @flyingrobots
    MemberAuthor

    PR #116 merged as ac42a88 and closes the focused diagnostic defect in #115: an undecodable job record no longer produces unsupported path-ref-stray findings. Docker regressions preserve genuine stray/orphan/name-mismatch diagnostics and verify the root and object inventory are unchanged. Operational lock-file and permission checks remain open here. Hook configuration is already reported by doctor_hook_policy and actual store Git operations disable hooks; the original per-job-ref lock-file examples also need updating for refs/locks/state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bad-codeCode smell, coupling, or fragility to pay down

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions