Skip to content

fix(server): harden COTP connection framing - #893

Open
gijzelaerr wants to merge 1 commit into
masterfrom
fix/889-890-server-transport
Open

fix(server): harden COTP connection framing#893
gijzelaerr wants to merge 1 commit into
masterfrom
fix/889-890-server-transport

Conversation

@gijzelaerr

Copy link
Copy Markdown
Owner

Summary

  • echo calling and called TSAP parameters in COTP Connection Confirm frames for Snap7-derived clients
  • start a fresh receive deadline after each complete TPKT header
  • treat payload timeouts as connection errors to prevent stream desynchronisation
  • add exact wire-format and deadline regression coverage

Verification

  • uv run pytest — 2076 passed, 82 skipped
  • uv run pre-commit run --all-files
  • uv build

Closes #889
Closes #890

@gijzelaerr

Copy link
Copy Markdown
Owner Author

@esternu Could you rerun the two pure-Python compatibility reproducers from #889 and #890 against commit c998860? This PR changes the COTP connection-confirmation framing and fragmented/coalesced request handling specifically around those failures. No physical PLC is needed; a pass or remaining traceback from both reproducers would close the validation loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant