Skip to content

fix(integrations): Gate REMOTE_ADDR on data_collection.user_info - #7298

Open
ericapisani wants to merge 1 commit into
masterfrom
py-2751-gate-remote-addr
Open

fix(integrations): Gate REMOTE_ADDR on data_collection.user_info#7298
ericapisani wants to merge 1 commit into
masterfrom
py-2751-gate-remote-addr

Conversation

@ericapisani

Copy link
Copy Markdown
Member

REMOTE_ADDR was previously set unconditionally in the request env for aiohttp, sanic, and tornado. Now it respects the data_collection.user_info experiment when data collection is enabled, falling back to the legacy unconditional behaviour otherwise.

Fixes PY-2751
Fixes #7297

REMOTE_ADDR was previously set unconditionally in the request env for
aiohttp, sanic, and tornado. Now it respects the data_collection.user_info
experiment when data collection is enabled, falling back to the legacy
unconditional behaviour otherwise.

Fixes PY-2751
Fixes #7297
@ericapisani
ericapisani requested a review from a team as a code owner August 28, 2026 19:09
@linear-code

linear-code Bot commented Aug 28, 2026

Copy link
Copy Markdown

PY-2751

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

119255 passed | ❌ 1 failed | ⏭️ 6762 skipped | Total: 126018 | Pass Rate: 94.63% | Execution Time: 418m 11s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +196
Passed Tests 📈 +195
Failed Tests 📈 +1
Skipped Tests

➕ New Tests (1)

View new tests
  • test_continuous_profiler_auto_start_and_stop_sampled[experiment-thread]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled[experiment-thread]

File: tests.profiler.test_continuous_profiler
Suite: py3.6-gevent
Error: AssertionError: profiler should not be running assert '160b380ae6cf4e4784280cffc84219d8' is None + where '160b380ae6cf4e4784280cffc84219d8' = get_profiler_id()

Stack Trace
tests/profiler/test_continuous_profiler.py:812: in test_continuous_profiler_auto_start_and_stop_sampled
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert '160b380ae6cf4e4784280cffc84219d8' is None
E    +  where '160b380ae6cf4e4784280cffc84219d8' = get_profiler_id()

✅ Patch coverage is 100.00%. Project has 2492 uncovered lines.
❌ Project coverage is 90.27%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    90.30%    90.27%    -0.03%
==========================================
  Files          193       193         —
  Lines        25601     25604        +3
  Branches      9436      9442        +6
==========================================
+ Hits         23116     23112        -4
- Misses        2485      2492        +7
- Partials      1435      1435         —

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address missing user_info data collection gates on REMOTE_ADDR property

1 participant