Skip to content

ref(aiohttp): Remove dead segment name code #7284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjq wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −18
Open

ref(aiohttp): Remove dead segment name code #7284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions sentry_sdk/integrations/aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
from sentry_sdk.integrations.logging import ignore_logger
from sentry_sdk.scope import Scope, should_send_default_pii
from sentry_sdk.sessions import track_session
from sentry_sdk.traces import (
SOURCE_FOR_STYLE as SEGMENT_SOURCE_FOR_STYLE,
)
from sentry_sdk.traces import (
NoOpStreamedSpan,
SegmentNameSource,
Expand Down Expand Up @@ -339,21 +336,11 @@ async def sentry_urldispatcher_resolve(
pass

if name is not None:
current_span = sentry_sdk.get_current_span()
if isinstance(current_span, StreamedSpan) and not isinstance(
current_span, NoOpStreamedSpan
):
current_span._segment.name = name
current_span._segment.set_attribute(
"sentry.segment.name.source",
SEGMENT_SOURCE_FOR_STYLE[integration.transaction_style].value,
)
else:
current_scope = sentry_sdk.get_current_scope()
current_scope.set_transaction_name(
name,
source=SOURCE_FOR_STYLE[integration.transaction_style],
)
current_scope = sentry_sdk.get_current_scope()
current_scope.set_transaction_name(
name,
source=SOURCE_FOR_STYLE[integration.transaction_style],
)

return rv

Expand Down
Loading