Skip to content

ref(stdlib): remove urllib3 workaround #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloDeputter merged 1 commit into from
Aug 28, 2026
+1 −4
Merged

ref(stdlib): remove urllib3 workaround #7283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sentry_sdk/integrations/stdlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,11 +459,8 @@ def close(self: "HTTPResponse") -> None:
self._sentrysdk_span = None # type: ignore[attr-defined]
_complete_span(span)

HTTPConnection.putrequest = putrequest # type: ignore[method-assign]
# patch `HTTPConnection.putrequest()` first. urllib3 < 1.25.9 inherits it, so
# wrapping AWS classes first would skip URL and span recording. Once boto3-v1.16.63
# support is dropped, we won't have to worry about this issue.
_patch_aws_connection()
HTTPConnection.putrequest = putrequest # type: ignore[method-assign]
Comment thread
pabloDeputter marked this conversation as resolved.
HTTPConnection.getresponse = getresponse # type: ignore[method-assign]
HTTPResponse.read = read # type: ignore[method-assign]
HTTPResponse.close = close # type: ignore[assignment,method-assign]
Expand Down
Loading