[myleshorton]

Summary

Follow-up to #9215: with the chevron slot fixed, the status dots still scatter horizontally because the latency label's width varies — 1347 ms is wider than 61 ms, and the dot sits to its left.

Two root causes, both verified:

• Urbanist ships no tnum OpenType feature (checked the font's GSUB/GPOS tables: ccmp, frac, kern, mark, mkmk only), so LatencyIndicator's existing FontFeature.tabularFigures() request is silently inert and even same-digit-count labels can vary.
• Latencies span 2–4 digits, which no tabular-figures setting could equalize anyway.

Fix: for measured labels, lay out an invisible widest-case 8888 ms template behind the end-aligned real label (same Visibility(maintainSize) idiom as #9215's ChevronPlaceholder). The label block's width is now constant for the current text style and scale factor, so the dot column is stable — with any font, any locale, and no hardcoded pixel width. If a label ever exceeds the template (5-digit latency), the Stack grows instead of clipping. Testing…/Unreachable labels keep their natural width: they're exceptional states and reserving Unreachable's width on every row would push all dots far left.

Testing

• New widget test: a 2-digit and a 4-digit measured label render the indicator at identical width (fails without the fix — the glyph counts differ even in the test font).
• test/features/vpn/: 39/39; full flutter test: 534/534; analyzer clean on the changed files.
• Font claim verified against the Urbanist woff2 served by Google Fonts (fontTools feature dump).

Risk

• UI-only, single widget. Riskiest aspect: the invisible template renders one extra Text per measured row — negligible, and excluded from semantics/hit-testing by Visibility(visible: false).

How to revert

Revert the commit; no state to undo.

Pre-PR review (local Codex gate)

• Rounds: 1 — final: round=1 range=origin/main...HEAD CODEX GATE: verdict=approve critical=0 important=0 minor=0 preexisting=0 reviewed=9
• Reviewed at: 081245bc1
• Exit: approve (the gate read the callers — server rows, single-city tile, smart-location tile — plus the Right-align latency labels on rows without a chevron #9215 chevron code, AppTile, and the text styles, with RTL, text-scale, and 5-digit cases in the prompt)
• Step back: not needed
• Fixed: none
• Dismissed: none
• Pre-existing (not introduced here, worth filing): none

🤖 Generated with Claude Code

https://claude.ai/code/session_01UG31BsLYqwPyN5StFB7RNN

Summary by CodeRabbit

• UI Improvements
  • Measured latency labels now occupy a consistent width, regardless of the number of digits displayed. Testing and unreachable status labels remain unchanged.
• Tests
  • Added coverage confirming that measured latency values with different digit counts render at the same width.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 30ad02af-11b7-45a5-9477-d0b631e10866

📥 Commits

Reviewing files that changed from the base of the PR and between 2af3e9c and 081245b.

📒 Files selected for processing: 2

• lib/features/vpn/latency_indicator.dart
• test/features/vpn/latency_indicator_test.dart

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Measured latency labels now use an invisible 8888 ms template to maintain their layout width. The row renders the label widget, and a widget test checks that two- and four-digit measured values occupy the same width.

Changes: Latency label layout

Layer / File(s)	Summary
Measured label width lib/features/vpn/latency_indicator.dart, test/features/vpn/latency_indicator_test.dart	Measured latency labels are overlaid on an invisible 8888 ms template. Other statuses remain plain text. The row renders the label widget, and a widget test compares the widths for 61 ms and 1347 ms.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related issues

• getlantern/engineering#4052: The issue covers latency values and status labels on server-location rows; this change adjusts the measured latency label layout.

Possibly related PRs

• getlantern/lantern#9211: This PR changes the LatencyIndicator introduced in PR #9211.
• getlantern/lantern#9215: This PR reserves measured-label width as a complementary part of the latency-column alignment work.

Merge Risk: ⚪ Minimal · up to 08124

No actionable merge-blocking risk is established by the supplied review evidence.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "Keep the latency dot in one column for measured rows" matches the main change. The PR puts an invisible 8888 ms template behind measured latency labels so the status dot stays in one colu…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "Keep the latency dot in one column for measured rows" matches the main change. The PR puts an invisible 8888 ms template behind measured latency labels so the status dot stays in one column despite varying label widths. The objectives and the widget test (61 ms vs 1347 ms same width) support this. The title is specific and does not use vague terms.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approved

The localized layout change includes a focused regression test, and no blocking issues were identified.

No open issues 🎉

What changed in this PR

Stabilizes the latency-dot column for measured server rows, complementing #9215’s chevron alignment fix.

Changes:

• Reserves label width with an invisible 8888 ms template while allowing longer labels to expand.
• Preserves natural widths for testing and unreachable states.
• Adds a regression test comparing indicator widths for two- and four-digit measurements.

File	Description
test/​features/​vpn/​latency_indicator_test.dart	Verifies equal indicator widths across different measured digit counts.
lib/​features/​vpn/​latency_indicator.dart	Reserves consistent measured-label width and end-aligns the visible text.

_{Review effort: Balanced}