Skip to content

fix(windows): prevent duplicate alert sounds - #78

Merged
gen2brain merged 1 commit into
gen2brain:masterfrom
sakkkurai:patch-1
Oct 20, 2026
Merged

gen2brain merged 1 commit into
gen2brain:masterfrom
sakkkurai:patch-1

Conversation

@sakkkurai

Copy link
Copy Markdown
Contributor

No description provided.

@sakkkurai

Copy link
Copy Markdown
Contributor Author

windows already have notification sound so messageBeep() isn't neccessary in main case and makes sound glitch.

video.mp4

sakkkurai added a commit to zenpaw-labs/skypaw that referenced this pull request Oct 12, 2026
there's also was created PR to lib, that we using for sending notifications. see here: gen2brain/beeep#78.
sakkkurai added a commit to zenpaw-labs/skypaw that referenced this pull request Oct 12, 2026
there's also was created PR to lib, that we using for sending notifications. see here: gen2brain/beeep#78.
sakkkurai added a commit to zenpaw-labs/skypaw that referenced this pull request Oct 12, 2026
there's also was created PR to lib, that we using for sending notifications. see here: gen2brain/beeep#78.

our builds will include this fix regardless of whether the pr gets merged upstream.
sakkkurai added a commit to zenpaw-labs/skypaw that referenced this pull request Oct 12, 2026
there's also was created PR to lib, that we using for sending notifications. see here:
gen2brain/beeep#78.

our builds will include this fix regardless of whether the pr gets merged upstream.
sakkkurai added a commit to zenpaw-labs/skypaw that referenced this pull request Oct 12, 2026
there's also was created PR to lib, that we using for sending notifications. see here: gen2brain/beeep#78.

our builds will include this fix regardless of whether the pr gets merged upstream.
@gen2brain
gen2brain merged commit bb308db into gen2brain:master Oct 20, 2026
3 checks passed
@gen2brain

Copy link
Copy Markdown
Owner

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants