Compose QR code with title and amount header for download - #658
Merged
Merged
Conversation
Some e-wallet apps (e.g. Dana) render the raw QR crop without context. Compose the download onto a white canvas with padding and the brand name plus the total on top of the code, instead of shipping the bare QR pixels. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bk6aVyMJwPGoRjwWvCoauJ
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds functionality to compose QR code images with a header containing title and amount information before download, improving the visual presentation of downloaded QR codes.
Key Changes
New
composeQrDownloadImagefunction inqrDownload.tsthat:ComposedQrImagewith the composed base64, width, and heightConstants for QR canvas styling (padding, fonts, heights, gaps) extracted to module-level for maintainability
Updated
QrisPaymentViewto:composeQrDownloadImagewith order brand name and formatted amountComprehensive test coverage for
composeQrDownloadImageincluding:Imageand canvas APIs for deterministic testingImplementation Details
The composition creates a canvas with:
https://claude.ai/code/session_01Bk6aVyMJwPGoRjwWvCoauJ