Skip to content

feat: deprecate translator methods #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
korikuzma wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

feat: deprecate translator methods #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/ga4gh/vrs/extras/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,14 @@ def __init__(
self.data_proxy = data_proxy
self.identify = identify
self.rle_seq_limit = rle_seq_limit
self.from_translators: dict[str, VariationFromStrProtocol] = {}
self.to_translators: dict[str, VariationToStrProtocol] = {}

self.from_translators: dict[
str, VariationFromStrProtocol
] = {} # Will be renamed to ``to_vrs_translators`` in v3.
self.to_translators: dict[
str, VariationToStrProtocol
] = {} # Will be renamed to ``from_vrs_translators`` in v3.

@deprecated("translate_from is deprecated and will be renamed to to_vrs in v3.")
def translate_from(
self, var: str, fmt: str | None = None, **kwargs
) -> models._VariationBase:
Expand Down Expand Up @@ -136,6 +141,7 @@ def translate_from(
msg = f"Unable to parse data as {', '.join(formats)}"
raise ValueError(msg)

@deprecated("translate_to is deprecated and will be renamed to from_vrs in v3.")
def translate_to(self, vo: models._VariationBase, fmt: str, **kwargs) -> list[str]:
"""Translate vrs object `vo` to named format `fmt`

Expand Down
Loading