Repository navigation
feat: add CORE_VERSION (gks-core) - #648
Merged
Merged
Conversation
jsstevenson
approved these changes
Aug 14, 2026
theferrit32
added a commit
to theferrit32/vrs-python
that referenced
this pull request
Oct 28, 2026
Forward-merge main into vrs/2.1 so it is no longer behind. Net change to vrs/2.1 is ga4gh#642 (is_intronic r. fix); the other main commits since the merge base (ga4gh#635, ga4gh#639, ga4gh#645, ga4gh#648) were already ported as parallel PRs. Conflict resolution: - src/ga4gh/core/models.py: conflict between ga4gh#645 (main) and vrs/2.1's restructured models (ga4gh#644 + gkm-core updates). Took vrs/2.1's version, which already includes the int Extension.value fix. - src/ga4gh/core/__init__.py: auto-merged without conflict but incorrectly, duplicating main's __version__ block (undefined `version`) and CORE_VERSION = "1.0.0" from ga4gh#648. Took vrs/2.1's version (CORE_VERSION from ga4gh.core.version, 1.3.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #646