Repository navigation
refactor: name real argument groups instead of dodging max-params - #85
Merged
Merged
Conversation
Read caption parts from named regex groups via matchAll instead of a rest parameter, and group the unit symbol and formatter into named SECONDS and MILLISECONDS units instead of an anonymous median/samples object. Refs furedea/dotfiles#247 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying furedea-com with
|
| Latest commit: |
3000fb3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ba121a8.furedea-com.pages.dev |
| Branch Preview URL: | https://refactor-name-real-argument.furedea-com.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
max-params を回避するためだけの引数グルーピングを，名前付きの概念または構造の変更に置き換える．挙動は変更しない．
Refs furedea/dotfiles#247
変更内容
src/data/article.tsconvertCaptionsの(_match, ...captures)matchAll）alt/url/captionを名前付きグループから読み，HTML 生成を 3 引数のcaptionFigureに分離tests/performance/performance_report.tsunitWithRangeの匿名{ median, samples }Unit）SECONDS/MILLISECONDS定数にまとめ，medianとsamplesは通常の引数に戻した挙動の固定
*で囲んだ画像キャプションの変換テストを追加（後方参照\k<marker>の確認）88 ms (50–121)）のテストを追加いずれも変更前のコードで通過することを確認済み．
確認
pnpm check: 成功lefthook run pre-commit --all-files: 成功🤖 Generated with Claude Code