Repository navigation
fix(tests): make git test wrappers exec the real git binary - #310
Merged
Merged
Conversation
Resolve git once from git --exec-path so wrappers no longer re-enter the Xcode shim through PATH and loop forever. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
cleanup_worktrees のテストが置く
gitwrapper は，shutil.which("git")の結果をexecしていた．/usr/binが先にある PATH ではそれが Xcode の shim になり，shim が PATH から git を探し直して wrapper を再び呼ぶため無限ループしていた．共通ヘルパーtests/runtime.pyのreal_git()がgit --exec-pathから本物の git を一度だけ割り出し，すべての wrapper がそれをexecする．本番コードは変更していない．変更前後
shutil.which("git")（shim のことがある）real_git()（git --exec-path配下の実体）/usr/binが先の PATH受け入れ条件
/usr/binが先の PATH でtest_cleanup_worktrees*.pyが全件通るCloses #307
🤖 Generated with Claude Code