Repository navigation
promote staging to main - #33
Merged
Merged
Conversation
The entry-point table and the two variables under it: who launches the process, and who holds the credential. The principle is the one reusable claim, extracted so it can be cited without the survey. markitdown now links to the survey it was the worked example for.
The pin from the browser-pinning guide was correct and the hook still failed, because the browser was never where the pin said it would be. puppeteer fetches its Chrome from a postinstall script into its own cache directory, and CI cached only the prek environment beside it. A cache hit then restored node_modules without re-running the install, so the hook had every dependency and no browser. Two changes, either of which would have been enough on its own: - Cache the two directories under one key, so a restore cannot bring back half of a hook environment. - Install the browser in the hook entry, naming no version so the pinned puppeteer resolves its own. This also covers npm 12, which declines to run install scripts by default and so would stop the postinstall download entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.