Tool booking - #449
Merged
Merged
Tool booking#449
Conversation
for tool bookings. I have tested it as much as possible.
georgelgeback
left a comment
georgelgeback
left a comment
Contributor
There was a problem hiding this comment.
We need to think more about the required permissions to add bookings, maybe we should add another tool_booking_request model for regular members? Everything else looks great though, smart solution for checking if there are too many booked tools in a range.
Contributor
|
@Knazeball If you fix the three comments I left I'll merge this in right away, just a ping as reminder |
…r ej vilka som redan har bokat dem
…etter when all three main data attributes (amount, start_time and end_time) is updated in the same way. Then none of these will be None.
Contributor
|
Sorry that I just left this branch without continuing. I looked through your changes and they look really good @georgelgeback and @erikmf123 ! I just very slightly altered update_tool_booking but reject these changes if you think they are not an improvement. |
Knazeball
approved these changes
Sep 23, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.