Repository navigation
wire rail: preserve resolved materials during mesh regeneration - #614
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge; no actionable bugs were found. SummaryTracks the last material assigned to a wire rail so mesh rebuilds keep replacements made by the material resolver.
Reviews (1) · Last reviewed commit: "wire rail: retain resolved materials whe..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire rails cache the imported placeholder material while a package is restored. When the table activates, their mesh rebuild can reassign that placeholder over the resolved material, rendering the rails white.
Track the last assigned material so a resolver replacement survives activation, mesh rebuilds and renderer recreation. Explicit inspector changes still win when no assignment has occurred in the current domain. Existing table packages work without re-exporting.
Validation: all 166 wire rail component and packaging tests pass, including three regression cases. Reloaded an existing package and visually verified reflective rails in both the Editor and the Windows standalone player. Reviewed with Opus 5.5.