Repository navigation
plugins: add shared settings and guided launch preparation - #613
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge; both previous findings are addressed, with no new actionable issues found. SummaryThis PR adds shared plugin settings and checks required integrations before launch.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin-owned paths, mixer channels and future shared settings can now appear on global Player pages while retaining one canonical plugin configuration. Plugins can also block launch with actionable requirements and opt required preparation actions into guided setup.
Validation: 99 portable Player API tests pass, including unsupported section handling, stop requests during pending startup, and owner-thread replay of held game state after preflight. Unity recompilation and discovery of the actual path/mixer consumers also pass. The consuming player and integration package were tested together through real archive preparation, verification, state initialization and automatic game launch in a Windows standalone build. Reviewed with Opus 5.5.