Conversation
github-actions
Bot
added
Curriculum material
|
🌐 Preview URL: https://pr-336.frcsoftware.org Changed pages |
karlolson5
reviewed
Sep 21, 2026
karlolson5
reviewed
Sep 21, 2026
zachwaffle4
requested changes
Oct 2, 2026
|
|
||
| CTRE uses a `CANBus` that is constructed with a `CANPort enum to specify which of Systemcore's CANBuses the device is connected too. | ||
| This enum is a field in the `CANPort` class and only CAN_S0 through CAN_S4 will ever be used since Systemcore only has five CAN Busses. | ||
| CTRE uses a `CANBus` that is constructed with a `CANPort` enum to specify which of Systemcore's CANBuses the device is connected too. |
Member
There was a problem hiding this comment.
I think it would be beneficial to explain CANPort when you mention bus ID the first time; CAN_S0 makes no sense without the context that it's really CANPort.CAN_S0.
| CTRE uses a `CANBus` that is constructed with a `CANPort enum to specify which of Systemcore's CANBuses the device is connected too. | ||
| This enum is a field in the `CANPort` class and only CAN_S0 through CAN_S4 will ever be used since Systemcore only has five CAN Busses. | ||
| CTRE uses a `CANBus` that is constructed with a `CANPort` enum to specify which of Systemcore's CANBuses the device is connected too. | ||
| This enum is a field in the `CANPort` class and only `CAN_S0` through `CAN_S4` will ever be used since Systemcore only has five CAN Busses. |
Member
There was a problem hiding this comment.
The enum is not a field in the CANPort class, CANPort itself is an enum. I'm unsure what this was trying to say.
Member
Author
There was a problem hiding this comment.
Not sure. That was already there in 1b
Co-authored-by: Zach Harel <zach.harel42@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Closes #334
Merge checklist: