Repository navigation
Fix enum comparisons with legacy Node type resolution - #97
Open
sophiehouser wants to merge 1 commit into
Open
sophiehouser wants to merge 1 commit into
sophiehouser wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK's legacy Node type resolution loads client responses from CommonJS declarations but public enums from ESM declarations. Direct status comparisons then trigger
no-unsafe-enum-comparison. Point the legacy/typesmapping at the same CommonJS declarations; runtime exports and modern resolution mappings stay unchanged.Regression coverage compiles a consumer using the public package entry points under Node, Node16, NodeNext, and Bundler resolution, including ESM and CommonJS variants. It verifies that response statuses and imported enums share the same compiler symbol, since typechecking alone accepts the duplicate declarations.
Validation: typecheck, test-file ESLint, and all eight enum tests pass. A separate consumer lint check reproduces the comparison error with the old mapping and passes with the fix. No API calls or credentials are needed.